Skip to content

[Automated] Update syft CLI Options#2637

Merged
thomhurst merged 1 commit into
mainfrom
automated/update-cli-options-syft
May 17, 2026
Merged

[Automated] Update syft CLI Options#2637
thomhurst merged 1 commit into
mainfrom
automated/update-cli-options-syft

Conversation

@thomhurst
Copy link
Copy Markdown
Owner

Summary

This PR contains automatically generated updates to syft CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels May 17, 2026
@thomhurst thomhurst enabled auto-merge (squash) May 17, 2026 03:20
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0 (≤ 20 complexity)

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@thomhurst thomhurst merged commit f571f91 into main May 17, 2026
11 of 12 checks passed
@thomhurst thomhurst deleted the automated/update-cli-options-syft branch May 17, 2026 03:29
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Summary

This automated PR updates the ModularPipelines.Syft package by regenerating it from the latest syft CLI help output. The only change is a timestamp update in AssemblyInfo.Generated.cs:

- [assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-05-10T03:37:29.2093425Z")]
+ [assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-05-17T03:19:19.7346916Z")]

No actual options classes were added, removed, or modified — syft's CLI interface hasn't changed between runs.


Observation: Noisy PRs When Nothing Substantive Changes

The current behaviour creates a PR every time the generator runs, even if the only difference is the GeneratedAt timestamp. This introduces unnecessary review noise and wastes CI minutes.

Why this matters architecturally: if syft ships a new release that does change options, that signal gets buried in a stream of timestamp-only PRs. Reviewers may start rubber-stamping these without reading them, which defeats the purpose of the PR gate.

A better approach would be to have the generator (or the surrounding automation) diff the content of options classes (excluding the timestamp) before deciding whether to open a PR:

# pseudo-logic in the generator workflow
if git diff --stat HEAD -- 'src/ModularPipelines.Syft/**' | grep -v 'AssemblyInfo.Generated.cs' | grep -q '.'; then
  # real option changes exist → open PR as normal
else
  # only the timestamp changed → commit directly to main (or skip entirely)
fi

Alternatively, the GeneratedAt timestamp could be omitted from the generated file altogether and tracked in git history instead, so a "no real changes" run produces a clean git diff and the automation never opens a PR.


Verdict

The change itself is correct and safe — there's nothing wrong with updating the timestamp. But the automation pattern is worth revisiting so PRs are only raised when the syft CLI actually changes, keeping the review queue meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant